fix duplicated leaf frame for dwarf unwinding #2811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already record the leaf frame in
set_initial_state
, so we don't need to record it again during the main unwinding loop.The FP unwinder handles this by recording the frame that was reached in each iteration of the loop, whereas the DWARF unwinder records the frame from the previous iteration of the loop. This PR changes the DWARF unwinder to match the behavior of the FP unwinder, fixing the issue.
FYI @metalmatze