*: Allow using persistence with WAL and object storage #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
persist
branch
4 times, most recently
from
ad2a24f
to
406a061
Compare
metalmatze
approved these changes
Jul 22, 2022
| @@ -140,13 +148,38 @@ func Run(ctx context.Context, logger log.Logger, reg *prometheus.Registry, flags | |||
| return runScraper(ctx, logger, reg, tracerProvider, flags, version, cfg) | |||
| } | |||
|
|
|||
| bucketCfg, err := yaml.Marshal(cfg.ObjectStorage.Bucket) | |||
| if err != nil { | |||
| level.Error(logger).Log("msg", "failed to marshal object storage bucket config", "err", err) | |||
There was a problem hiding this comment.
Aren't we logging the same error twice if we also return it?
Lines 57 to 61 in e48920c
I can see this was already a thing with the error handling in this function before so I'm fine with having these in. Maybe creating an issue to clean it up would be good?
hardys
pushed a commit
to hardys/parca-docs
that referenced
this pull request
Nov 22, 2022
Since parca-dev/parca#1403 the syntax here doesn't work, so align with the new parca.yaml from the main repo
kakkoyun
pushed a commit
to parca-dev/docs
that referenced
this pull request
Nov 22, 2022
Since parca-dev/parca#1403 the syntax here doesn't work, so align with the new parca.yaml from the main repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugs all the persistence features of FrostDB into Parca.