Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a few function names on comments #2031

Merged
merged 1 commit into from Nov 9, 2022
Merged

fix a few function names on comments #2031

merged 1 commit into from Nov 9, 2022

Conversation

cuishuang
Copy link
Contributor

No description provided.

@cuishuang
fix a few function names on comments
28699ee 
Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang cuishuang requested a review from a team as a code owner November 3, 2022 12:34
kakkoyun
kakkoyun approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it 🤗

@kakkoyun kakkoyun enabled auto-merge (squash) November 4, 2022 18:08
brancz
brancz approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brancz brancz disabled auto-merge November 9, 2022 13:20
@brancz brancz merged commit 1200950 into parca-dev:main Nov 9, 2022
@manojVivek
Copy link
Contributor

@all-contributors Please add @cuishuang for docs.

@allcontributors allcontributors bot mentioned this pull request Nov 10, 2022
Merged
@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @cuishuang! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cuishuang @manojVivek @kakkoyun @brancz