Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/query: Fix flamegraph function deduplication #2055

Merged
merged 1 commit into from
Nov 8, 2022
Merged

pkg/query: Fix flamegraph function deduplication #2055

merged 1 commit into from
Nov 8, 2022

Conversation

brancz
Copy link
Member

@brancz brancz commented Nov 8, 2022 •
edited

We were resetting all function IDs to be "", which caused functions to override each other seemingly randomly.

@brancz brancz requested a review from a team as a code owner November 8, 2022 10:03
@metalmatze
Copy link
Member

There are some tests that need to be updated.
I remember now why I set Id="", it was to not send those strings over the wire too. Maybe we need to somehow remove them later in the calls, probably after the aggregation.

@brancz
Copy link
Member Author

brancz commented Nov 8, 2022

Yep, just pushed a fix to do exactly that.

@brancz brancz merged commit a87b786 into main Nov 8, 2022
@brancz brancz deleted the dedup-fg branch November 8, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brancz @metalmatze