ft: Filter by function functionality added to ProfileView
#2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicawoj
approved these changes
Nov 9, 2022
brancz
reviewed
Nov 9, 2022
pkg/query/columnquery.go
Outdated
| @@ -196,6 +221,7 @@ func (q *ColumnQueryAPI) renderReport(ctx context.Context, p *profile.Profile, t | |||
| Report: &pb.QueryResponse_Top{Top: top}, | |||
| }, nil | |||
| case pb.QueryRequest_REPORT_TYPE_CALLGRAPH: | |||
| fmt.Println("callgraph") | |||
There was a problem hiding this comment.
Ahh, yes, my bad.
pkg/query/columnquery.go
Outdated
| func filterProfileData(p *profile.Profile, filterQuery string) *profile.Profile { | ||
| filteredSamples := []*profile.SymbolizedSample{} | ||
| for _, s := range p.Samples { | ||
| var lines []profile.LocationLine |
There was a problem hiding this comment.
We don't need to copy here. I would suggest the inside of this loop should be extracted to a separate function that's just called keepSample and if it returns true, then we append to filteredSamples. All the keepSample function then does is loop over all lines of all locations and on the first match it returns true and otherwise if no location line contained the search string, then it returns false.
yomete
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.