pkg/scrape: Allow profiles to be treated as already normalized #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this may be necessary for some pprof HTTP endpoints, we have encountered others now that are already normalized, in which case normalizing them again is incorrect.
|
Very useful, thank you! |
fabxc
pushed a commit
to fabxc/parca
that referenced
this pull request
Dec 5, 2022
…-dev#2124) While this may be necessary for some pprof HTTP endpoints, we have encountered others now that are already normalized, in which case normalizing them again is incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this may be necessary for some pprof HTTP endpoints, we have encountered others now that are already normalized, in which case normalizing them again is incorrect.
This is save to be added like this without changing existing behavior, as the value defaults to false which is the currently used value before this patch.