Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Using a virtual table component to improve TopTable performance and compare option added to benchmark runner #2225

Merged
merged 34 commits into from
Dec 13, 2022

Conversation

manojVivek
Copy link
Contributor

@manojVivek manojVivek commented Dec 6, 2022

Benchmark comparison with the previous implementation:

Compare with topTableBefore:
┌─────────┬────────────────┬────────────────────────────┬────────────────────────────┬────────────────────────────┬────────────────────────────┬────────────────────────────┬────────────────────────────┐
│ (index) │      name      │            mean            │            min             │            max             │            p50             │            p75             │            p90             │
├─────────┼────────────────┼────────────────────────────┼────────────────────────────┼────────────────────────────┼────────────────────────────┼────────────────────────────┼────────────────────────────┤
│    0    │ 'TopTable-10M' │ '39.124 (-16.28, -29.38%)' │ '26.333 (-19.17, -42.13%)' │   '92 (+17.00, +22.67%)'   │ '35.333 (-19.17, -35.17%)' │ '39.667 (-17.83, -31.01%)' │ '41.667 (-17.83, -29.97%)' │
│    1    │ 'TopTable-1M'  │ '19.371 (-10.19, -34.47%)' │ '14.333 (-8.92, -38.35%)'  │ '30.167 (-14.33, -32.21%)' │ '18.167 (-9.83, -35.12%)'  │   '21 (-9.25, -30.58%)'    │ '23.167 (-12.17, -34.43%)' │
│    2    │ 'TopTable-20M' │ '51.382 (-13.76, -21.13%)' │ '30.667 (-24.83, -44.74%)' │ '276 (+187.00, +210.11%)'  │ '40.333 (-21.67, -34.95%)' │   '49 (-21.00, -30.00%)'   │  '62.5 (-13.50, -17.76%)'  │
└─────────┴────────────────┴────────────────────────────┴────────────────────────────┴────────────────────────────┴────────────────────────────┴────────────────────────────┴────────────────────────────┘

Fixes #2133.

@manojVivek manojVivek requested a review from a team as a code owner December 6, 2022 09:22
@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
parca-ui ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 11:03AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ui-documentation ⬜️ Ignored (Inspect) Dec 6, 2022 at 11:03AM (UTC)

Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice work

@brancz brancz merged commit a27931e into main Dec 13, 2022
@brancz brancz deleted the toptable-fix branch December 13, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmark compare capability to the component benchmark runner.
3 participants