Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/packages/app/web: Hide agent or scraper target sections if non-existing #2227

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

metalmatze
Copy link
Member

Previously we still showed the Parca Agents section, even though that Parca never received a single request from a Parca Agent.
before

By checking if there are any agents in the array we can hide the section entirely if there are none.

after

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
parca-ui ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 1:29PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ui-documentation ⬜️ Ignored (Inspect) Dec 6, 2022 at 1:29PM (UTC)

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants