Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: FilterByFunction improvements #2236

Merged
merged 4 commits into from
Dec 7, 2022
Merged

ui: FilterByFunction improvements #2236

merged 4 commits into from
Dec 7, 2022

Conversation

manojVivek
Copy link
Contributor

Implements:

  • filterByFunction feature flag remove
  • Added user preference option to highlight the nodes after filtering
  • Added clear option to the input box
  • Added tracing for the backend function

Screenshot 2022-12-07 at 2 32 22 PM

@manojVivek manojVivek requested review from a team as code owners December 7, 2022 09:04
brancz
brancz approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! lgtm

@manojVivek manojVivek enabled auto-merge (squash) December 7, 2022 09:20
@manojVivek manojVivek merged commit 501c6d0 into main Dec 7, 2022
@manojVivek manojVivek deleted the filterByFunction branch December 7, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manojVivek @brancz