pkg/debuginfo: Allow uploads to be done via signed URLs #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
changed the title
|
Opening this early to get feedback. Before merging here I would like to at least implement this functionality in the debuginfo-cli for testing and then continue in parca-agent once merged here. |
|
This will have failing |
brancz
force-pushed
the
signed-url-uploads
branch
from
77f76b3
to
73b6660
Compare
kakkoyun
reviewed
Dec 8, 2022
| bucket objstore.Bucket | ||
| } | ||
|
|
||
| func NewFetcher( |
brancz
force-pushed
the
signed-url-uploads
branch
from
5bf139d
to
87230db
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
87230db
to
4722cab
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
4722cab
to
6576685
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
6576685
to
8e95b65
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
8e95b65
to
5399ddc
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
5399ddc
to
d8bb496
Compare
This was referenced Dec 9, 2022
brancz
force-pushed
the
signed-url-uploads
branch
from
d8bb496
to
070bb48
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
070bb48
to
e0d710a
Compare
brancz
force-pushed
the
signed-url-uploads
branch
from
e0d710a
to
cf22eea
Compare
brancz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2237 with Google Cloud Storage being the first supported provider. Parca will error on startup with another provider is attempted to be used.
Here's a flow diagram of how debuginfo uploads are going to work from now on: