Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Github Star button and Release Notes Viewer which show the release notes within Parca UI #2366

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

manojVivek
Copy link
Contributor

The following are the triggers for the Release Notes Viewer Modal:

  • Whenever a new version of Parca is deployed.
  • Whenever the user clicks on the version number in the navbar.

Screencast:
https://user-images.githubusercontent.com/1283424/210308803-6db64999-801f-4a7b-887e-a5a1a794d5c5.mov

… is deployed or when the version number is clicked
@manojVivek manojVivek requested a review from a team as a code owner January 3, 2023 06:25
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! (Maybe we can add a "What's new?" or something to indicate that the version is click-able? Right now it's not very obvious unless you hover over it)

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui-documentation 🔄 Building (Inspect) Jan 3, 2023 at 10:18AM (UTC)

@manojVivek
Copy link
Contributor Author

Very cool! (Maybe we can add a "What's new?" or something to indicate that the version is click-able? Right now it's not very obvious unless you hover over it)

Done, added "What's new?" next to the version like this:
Screenshot 2023-01-03 at 3 49 08 PM

@brancz
Copy link
Member

brancz commented Jan 3, 2023

Love it!

@manojVivek manojVivek merged commit 7999397 into main Jan 3, 2023
@maxbrunet maxbrunet deleted the release-notes-viewer branch May 17, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants