Visualization Panels drag n drop feature #2403
Conversation
monicawoj
force-pushed
the
panel-drag-n-drop
branch
from
6708d27
to
7c1ddc0
Compare
|
Monica, looks like there is a bug when I drag a panel and drop it in the same position. It still swaps them. Screen.Recording.2023-01-16.at.9.49.38.AM-1.mov |
Thanks for catching this, Manoj! I'll look into it! |
|
Looooove it! lgtm from a user perspective! Teeny tiny nit: Since each panel already has the X to close it, I don't think the reset button is needed. I don't feel strongly at all though, it would just be one less thing on the screen. |
| className={cx(isMultiPanelView ? 'visible' : 'invisible')} | ||
| {...provided.dragHandleProps} | ||
| > | ||
| <DragIndicator /> |
There was a problem hiding this comment.
Shall we replace this icon with the dots drag handle icon? <Icon icon="material-symbols:drag-indicator" />
I feel that icon is more universal, and this one looks a bit confusing, like the hamburger menu.
Yesss! That's a great point. I think the Reset button doesn't add any new functionality here. Will remove it |
Allows you to drag and drop the different visualization views (switch from right to left and vice-versa) when there are 2 panels. The URL is also updated when the positions of the panels are swapped.