Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix license pre-commit hook #2602

Merged
merged 2 commits into from
Feb 16, 2023
Merged

chore: fix license pre-commit hook #2602

merged 2 commits into from
Feb 16, 2023

Conversation

Franqsanz
Copy link
Contributor

@Franqsanz Franqsanz commented Feb 15, 2023 •
edited by maxbrunet

Closes #2599

@Franqsanz Franqsanz requested a review from a team as a code owner February 15, 2023 20:11
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@pre-commit-ci-lite pre-commit-ci-lite bot requested review from a team as code owners February 15, 2023 20:28
maxbrunet
maxbrunet approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@maxbrunet maxbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Franqsanz
Copy link
Contributor Author

You are welcome!

kakkoyun
kakkoyun approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brancz brancz merged commit 95ddce9 into parca-dev:main Feb 16, 2023
@manojVivek
Copy link
Contributor

@all-contributors Please add @Franqsanz for code.

@allcontributors allcontributors bot mentioned this pull request Oct 25, 2023
Merged
@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @Franqsanz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@maxbrunet maxbrunet maxbrunet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix license pre-commit hook
6 participants
@Franqsanz @CLAassistant @manojVivek @kakkoyun @maxbrunet @brancz