ui: Improve showing filtered and trimmed nodes in ProfileIcicleGraph

[metalmatze]

If nothing gets filtered and trimmed the icicle graph now looks like this (see the line at the bottom).

With trimming enabled:

With filtering by function (for sort)

And finally with both trimming and filtering.

[metalmatze]

Oh, seems like #2756 created a merge conflict. I'll rebase these tomorrow.

Other follow-ups are:

• Tooltip need to use the max unfiltered total value (solves feature: searching in flamegraphs without recalculating the % of cycles #2719)
• Call graphs need the same capabilities.

[brancz]

Super cool!! I think the indicating text should be above the icicle graph as it's unpredictable how large it may be so you may not even know if that text is there just because the icicle graph is too tall.

[metalmatze]

Super cool!! I think the indicating text should be above the icicle graph as it's unpredictable how large it may be so you may not even know if that text is there just because the icicle graph is too tall.

It was there before and I moved it below the graph. It's mostly debugging information that's there when needed but nothing that usually concerns users unless they look for it.
I think we, as developers, are biased towards thinking the information is important because we think in terms of samples and filtering and trimming. It's still there, just not at the very top.

[metalmatze]

I'm writing and updating the flamegraph_table_test.go cases now. 😌

[brancz]

Alright happy with trying like this. I'm not convinced if I'm honest but I was wrong about function filtering as well, so I'm very happy to give it a shot and build an opinion again after using it a bit.

[yomete]

lgtm!

[manojVivek]

Lgtm!