proto/parca/share: Add total and filtered to QueryResponse #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes have been made to the Parca QueryResponse too and the UI of pprof.me expects these to be there now. The same seems fine to do for the share proto.
javierhonduco
approved these changes
Mar 27, 2023
Make FilterProfileData public to be usable from pprof.me too.
Indeed. Maybe that's one of the few downsides of being backward compatible. 😃 |
brancz
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have been made to the Parca QueryResponse too and the UI of pprof.me expects these to be there now. The same seems fine to do for the share proto.