Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropdown component #2947

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix dropdown component #2947

merged 1 commit into from
Apr 6, 2023

Conversation

monicawoj
Copy link
Contributor

This PR introduces a fix to the dropdown options not being fixed to the dropdown button. When Parca was used within a different application (such as Polar Signals Cloud) the dropdown options position changed on page scroll

Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@brancz brancz merged commit 0f17ef8 into main Apr 6, 2023
@brancz brancz deleted the select-component-fix branch April 6, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Something about the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants