Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .goreleaser.yml #3107

Merged
merged 4 commits into from
May 11, 2023
Merged

Update .goreleaser.yml #3107

merged 4 commits into from
May 11, 2023

Conversation

susarlanikhilesh
Copy link
Contributor

Add windows to goos to build release binary

Add windows to goos to build release binary
@susarlanikhilesh susarlanikhilesh requested a review from a team as a code owner May 11, 2023 07:51
@brancz
Copy link
Member

brancz commented May 11, 2023

Sorry looks like we didn't allow-list the .goreleaser.yml file so the dry-run job is being skipped, can you add the .goreleaser.yml file in this list:

".github/workflows/release-dry-run.yml",

Add goreleaser to check test for dry run
@CLAassistant
Copy link

CLAassistant commented May 11, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! More binaries! 🎉

@metalmatze metalmatze enabled auto-merge (squash) May 11, 2023 16:32
@metalmatze metalmatze merged commit eab72d5 into parca-dev:main May 11, 2023
30 of 32 checks passed
@manojVivek
Copy link
Contributor

@all-contributors Please add @susarlanikhilesh for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @susarlanikhilesh! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants