ui: Remove useEffect fn responsible for resetting current icicle path

[yomete]

This fixes the bug in #1991.

Steps to reproduce bug

• Pull up any icicle graph
• Apply a function filter
• Expand something in the icicle graph
• Click on root node
• Remove function filter
• From now on anything you click on in the icicle graph has this bug.

A couple of things to note:

TL:DR: Removed the navigateTo function as a dependency in the useEffect hook in the in the useURLState hook.

This bug doesn't seem to happen in Parca but only on PSC. After some investigating, I discovered this is because this useEffect keeps firing after a function filter has been removed i.e. setting the curPath to be an array, effectively causing the icicle graph to reset immediately after any clicking interaction with it.

Since this only takes place after the function filter is removed, I was able to isolate (did this by commenting the setStoreValue line out, and manually updating the URL with a filter_by_function query param and then deleting it. The icicle graph did not reset after this manual update) the bug to the setStoreValue function in the FilterByFunctionbutton component. The setStoreValue function is retrieved from the useURLState hook.

Therefore the reason for the infinite re-rendering had to be in the useURLState hook, and probably the useEffect hook, which had a couple of dependencies, which it used to determine whether to re-render. So I thought to remove the navigateTo function as a dependency in the useEffect hook in the in the useURLState hook.

Screen.Recording.2023-05-25.at.17.27.43.480.mov

[yomete]

@manojVivek @monicawoj since y'all worked originally on this hook, do you think this changes anything for the hook's functionality?

[metalmatze]

How many developers suffer each day because of this? 😂
Nice find!

[monicawoj]

ui/packages/shared/components/src/hooks/useURLState.tsx

@yomete I think this should be ok. The difference between Parca and PSC is in fact what is provided to the navigateTo prop. It's likely creating a new object every time in PSC and thus the prop is changing on every render. Another approach would be to attempt to use a useCallback hook for a shallow comparison of navigateTo but I think your solution should suffice for now - good find!