bug fix: corrected the key for profile-selector #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
metalmatze
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Very nice! Thank you so much!
Seems like fgprof sets the period type and unit correctly since felixge/fgprof#17 which is great, but broke our UI since.
|
@all-contributors Please add @themohammadsa for code. |
|
I've put up a pull request to add @themohammadsa! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
Improve fgprof profiles in profile types dropdown
📓 Referenced Issue
Fixes: #3199
ℹ️ About the PR
Corrected the key value so that the appropriate dropdown value is shown.
🖼️ Screenshots