pkg/debuginfo: Improve debuginfod client #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
debuginfod-client-improved
branch
2 times, most recently
from
cb878c0
to
1e76300
Compare
metalmatze
approved these changes
Jul 6, 2023
pkg/debuginfo/debuginfod.go
Outdated
|
|
||
| func (c *DebuginfodExistsClientCache) Exists(ctx context.Context, buildID string) (bool, error) { | ||
| if v, ok := c.lruCache.Get(buildID); ok { | ||
| if time.Since(v.lastResponseTime) < 10*time.Minute { |
brancz
force-pushed
the
debuginfod-client-improved
branch
3 times, most recently
from
afd348d
to
c1c9044
Compare
kakkoyun
approved these changes
Jul 6, 2023
|
I'm gonna test this on Polar Signals Cloud before merging here. I'll let y'all know how it goes. |
brancz
force-pushed
the
debuginfod-client-improved
branch
2 times, most recently
from
a6379db
to
b9a8d7c
Compare
brancz
force-pushed
the
debuginfod-client-improved
branch
from
b9a8d7c
to
97e7367
Compare
brancz
force-pushed
the
debuginfod-client-improved
branch
from
97e7367
to
4bdb0f5
Compare
brancz
force-pushed
the
debuginfod-client-improved
branch
from
4bdb0f5
to
71ab963
Compare
brancz
force-pushed
the
debuginfod-client-improved
branch
from
71ab963
to
9dccd43
Compare
brancz
force-pushed
the
debuginfod-client-improved
branch
from
9dccd43
to
2c184a3
Compare
brancz
force-pushed
the
debuginfod-client-improved
branch
from
2c184a3
to
5ae657a
Compare
This introduces a few improvements: * Parallelize debuginfod client requests. * Cache exists responses from upstream servers for 10 minutes. * Make caching of debuginfod blobs explicit on object storage (per debuginfod server). * Retrieve debuginfod binaries only from the server that it was previously identified to be available from. * Add tracing for HTTP client requests.
brancz
force-pushed
the
debuginfod-client-improved
branch
from
5ae657a
to
a38b082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a few improvements:
Closes #3028