parca: add --storage-snapshot-trigger-size #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asubiotto
force-pushed
the
alfonso-snapshot
branch
from
eba61cf
to
c1ce115
Compare
|
Looks like |
Parca would previously not snapshot frostdb data. This commit enables snapshotting by default each 1/4 of maximum active memroy and exposes a flag to tune this snapshot trigger size further. This allows recovery to be much faster than replaying all writes from the WAL. Users that would previously see the parca server take a long time to start or have the impression that the server was hung indefinitely during startup will benefit from this commit.
asubiotto
force-pushed
the
alfonso-snapshot
branch
from
c1ce115
to
b1c4e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parca would previously not snapshot frostdb data. This commit enables snapshotting by default each 1/4 of maximum active memroy and exposes a flag to tune this snapshot trigger size further. This allows recovery to be much faster than replaying all writes from the WAL.
Users that would previously see the parca server take a long time to start or have the impression that the server was hung indefinitely during startup will benefit from this commit.
Fixes #3430