ui/packages/profile: Disable automatic retries for merge queries #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 3 of 204 screens tested: view and approve differences detected. Last updated for commit ac10891. This comment will update as new commits are pushed. |
thorfour
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent conversation @thorfour brought up that expensive queries can take up to 10min to fail.
It seems like the query itself fails a lot quicker but only after several retries the error is shown to the user.
This change will disable retries for the merge queries.
All other API calls should still be retried, which is fine as they are usually a lot cheaper.