Fix for panic when building from dictionaries #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
force-pushed
the
fix-build-flamegraph-empty-dictionaries
branch
from
be40f30
to
2437769
Compare
brancz
approved these changes
Aug 2, 2023
|
✅ Meticulous spotted zero visual differences across 352 screens tested: view results. Last updated for commit 1625900. This comment will update as new commits are pushed. |
When a dictionary only contains null items it contains an empty dictionary. So it's invalid to retrieve an index from the dictionary if the value is null. This adds a check on the dictionary len, and in the case of it being 0; it treats it as a null value.
thorfour
force-pushed
the
fix-build-flamegraph-empty-dictionaries
branch
from
2437769
to
1625900
Compare
brancz
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dictionary only contains null items it contains an empty dictionary. So it's invalid to retrieve an index from the dictionary if the value is null.
This adds a check on the dictionary len, and in the case of it being 0; it treats it as a null value.