pkg/query: Fix cases where dicts are empty #3580
Conversation
|
🤖 Meticulous replayed 50 user sessions and took 214 screenshots. Meticulous has not yet run on cc5988a of the main branch and so there was nothing to compare against. If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch. Last updated for commit 50e50c3. This comment will update as new commits are pushed. |
| if lineRow >= 0 && r.LineFunction.IsValid(lineRow) && len(r.LineFunctionNameDict.Value(r.LineFunctionName.GetValueIndex(lineRow))) > 0 { | ||
| _ = fb.builderFunctionName.Append(r.LineFunctionNameDict.Value(r.LineFunctionName.GetValueIndex(lineRow))) | ||
| } else { | ||
| if r.LineFunctionNameDict.Len() == 0 { |
There was a problem hiding this comment.
nit: I think you can collapse both AppendNull branches by adding the inverse of this Len check to lineRow >= 0
There was a problem hiding this comment.
Yeah I agree this needs some refactoring, but this is gonna change with unifying dictionaries anyway so I kept it consistent with the rest of the codebase.
| fb.builderFunctionSystemName.AppendNull() | ||
| } else { | ||
| if lineRow >= 0 && r.LineFunction.IsValid(lineRow) && len(r.LineFunctionSystemNameDict.Value(r.LineFunctionSystemName.GetValueIndex(lineRow))) > 0 { |
There was a problem hiding this comment.
It feels like the case implementation could be a helper function used by the branches. Maybe for a later refactoring.
No description provided.