Improve flamegraph rendering performance #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some benchmarks this has a huge improvement: ``` $ benchstat -delta-test=none old.txt new.txt name old time/op new time/op delta ArrowFlamegraph-10 147s ± 0% 105s ± 0% -28.38% ```
Profiling data showed that the "map" access and iteration resulted in large amounts of CPU usage.
Profiling data showed that allocating these slices new all the time is very expensive: https://pprof.me/5bf3731
Profiling data suggested that ~13% of CPU time is spent in building these maps and performing lookups in them.
Tracking the count is fairly expensive according to profiling data, and all we need to know is whether labels exist or not.
|
✅ Meticulous spotted zero visual differences across 233 screens tested: view results. Last updated for commit 653ca86. This comment will update as new commits are pushed. |
metalmatze
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes we can render ~800k unique stacks within ~2s. There's still more that can be done, but I felt like this would be a good check in.
All these changes have already been verified to be working as expected by running them on Polar Signals Cloud for some time.