Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Graph - click info panel #3908

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Metrics Graph - click info panel #3908

merged 6 commits into from
Oct 13, 2023

Conversation

monicawoj
Copy link
Contributor

@monicawoj monicawoj commented Oct 12, 2023

Implements an info panel to inform users of what different types of clicks can do in the Metrics Graph

Design: https://www.figma.com/file/sMMnQwWpPovvn5JM3vhwL7/Parca?type=design&node-id=492-245232&mode=design&t=sNbDSDXIRgg4Om5G-4

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 12, 2023

🤖 Meticulous spotted visual differences in 96 of 224 screens tested: view and approve differences detected.

Last updated for commit b3e8ef3. This comment will update as new commits are pushed.

Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to target dark mode styling, other than that lgtm!
image

@monicawoj
Copy link
Contributor Author

Looks like we need to target dark mode styling, other than that lgtm! image

Ah yes, good catch! Will modify that!

@monicawoj monicawoj merged commit 04c9d4b into main Oct 13, 2023
35 of 38 checks passed
@monicawoj monicawoj deleted the click-info-panel branch October 13, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants