Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile for parca server #4257

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jan 11, 2024

If /data doesn't exist, nobody cannot create it so it fails all the time.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024

CLA assistant check
All committers have signed the CLA.

@metalmatze
Copy link
Member

In which scenario does this fail? Please elaborate. Thanks!

@orgads
Copy link
Contributor Author

orgads commented Jan 16, 2024

I'm just running the server as a container, and on each mapping it receives, there's an error.

Server:

docker run --rm -p 7070:7070  ghcr.io/parca-dev/parca:v0.20.0 /parca

Client:

docker run --rm --privileged --pid host ghcr.io/parca-dev/parca-agent:v0.28.0 /bin/parca-agent --node=docker-test --remote-store-address=$ip:7070 --remote-store-insecure

Server side:

level=error ... grpc.error="mark debuginfo upload as uploading via gRPC: write debuginfo metadata to object storage: mkdir /data: permission denied" grpc.time_ms=0.183

Client side:

level=error ... msg="upload mapping" err="failed to ensure debug information uploaded: initiate upload: rpc error: code = Unknown desc = mark debuginfo upload as uploading via gRPC: write debuginfo metadata to object storage: mkdir /data: permission denied" buildid=9042a6de34394719252c50aed79cdbabdff902a9 filepath=/proc/13207/root/usr/lib/x86_64-linux-gnu/libldap.so.2.0.200

@metalmatze
Copy link
Member

Excellent, thanks for those commands!
I was able to reproduce it. This should be fixed.

@orgads
Copy link
Contributor Author

orgads commented Jan 16, 2024

The failing test doesn't look related.

auto-merge was automatically disabled January 16, 2024 14:30

Head branch was pushed to by a user without write access

@orgads
Copy link
Contributor Author

orgads commented Jan 16, 2024

Rebased

If `/data` doesn't exist, `nobody` cannot create it so it fails all the time.
@orgads
Copy link
Contributor Author

orgads commented Feb 1, 2024

Rebased

@metalmatze metalmatze merged commit 5f7a27b into parca-dev:main Feb 3, 2024
29 of 33 checks passed
@orgads orgads deleted the patch-1 branch February 3, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants