Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Migrating from babel to swc for js transpiling #4315

Merged
merged 13 commits into from
Feb 22, 2024
Merged

Conversation

manojVivek
Copy link
Contributor

@manojVivek manojVivek commented Feb 21, 2024

This shaves off some 30-50s off the build and lint workflows.

But there is scope to cut down another 15-25s if we migrate all shared package transpiling to swc as well. Right now, I haven't done that as swc strips out all type metadata from the compiled files and this is resulting in some lint errors.
The fix is to do consistent type imports/exports which involve a lot of code changes, so saving for the next phase of improvement.

@manojVivek manojVivek requested a review from a team as a code owner February 21, 2024 04:49
Copy link

alwaysmeticulous bot commented Feb 21, 2024

✅ Meticulous spotted zero visual differences across 373 screens tested: view results.

Last updated for commit bfc5167. This comment will update as new commits are pushed.

@manojVivek manojVivek requested a review from a team as a code owner February 21, 2024 11:15
@brancz
Copy link
Member

brancz commented Feb 21, 2024

Seriously awesome! lgtm

@manojVivek manojVivek merged commit e157a7c into main Feb 22, 2024
33 of 34 checks passed
@manojVivek manojVivek deleted the ui-swc-build branch February 22, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants