area/ui: fix bug in relative range picker #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 24 of 524 screens tested: view and approve differences detected. Last updated for commit a7d410c. This comment will update as new commits are pushed. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ui/packages/shared/components/src/DateTimeRangePicker/RelativeDatePicker/index.tsx
Fixed
Show fixed
Hide fixed
Fix CodeQL error `Polynomial regular expression used on uncontrolled data` by limiting the input size and ensuring the regular expression is applied to controlled data, reducing the risk of ReDoS attacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where typing something like
1win the relative range picker and then hittingenterresets the input to15m. This was happening because we were not handling cases for where users are typing in week ranges. This has been added now.