Validate labels for profiles received from agent #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brancz, Should I have sanitized the labels instead? |
|
I think when this happens we should just fail the request and tell the user that they were trying to write invalid data. |
Sylfrena
force-pushed
the
validate-labels
branch
from
24bdeb9
to
c2fa27e
Compare
Sylfrena
force-pushed
the
validate-labels
branch
2 times, most recently
from
413e491
to
6ef645b
Compare
Sylfrena
force-pushed
the
validate-labels
branch
from
6ef645b
to
2636d11
Compare
brancz
reviewed
Apr 5, 2022
kakkoyun
reviewed
Apr 5, 2022
Add a test for the same as well.
Sylfrena
force-pushed
the
validate-labels
branch
from
2636d11
to
1167c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #817