env.sh: add support for arm64 #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we download the x86 binaries even on arm, let's fetch the `tilt` + `minikube` binaries for the matching architecture Had to bump `ctlptl` to 0.5.1 as they started generating the arm64 builds starting that version. Changes between [v0.5.0-v0.5.1](tilt-dev/ctlptl@v0.5.0...v0.5.1) **Test plan**: ```shell $ ./env.sh % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 35 68.2M 35 24.4M 0 0 6040k 0 0:00:11 0:00:04 0:00:07 6039k^C [vagrant@bazinga parca]$ ./env.sh % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 68.2M 100 68.2M 0 0 6127k 0 0:00:11 0:00:11 --:--:-- 6057k + tar -xzv tilt + curl -fsSL https://github.com/tilt-dev/tilt/releases/download/v0.27.0/tilt.0.27.0.linux.arm64.tar.gz tilt + copy_binary + [[ :/home/vagrant/.local/bin:/home/vagrant/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/usr/local/go/bin:/bin:/usr/local/go/bin:/home/vagrant/go/bin: == *\:\/\h\o\m\e\/\v\a\g\r\a\n\t\/\.\l\o\c\a\l\/\b\i\n\:* ]] + '[' '!' -d /home/vagrant/.local/bin ']' + mv tilt /home/vagrant/.local/bin/tilt + set +x Tilt installed! For the latest Tilt news, subscribe: https://tilt.dev/subscribe Run `tilt up` to start. ctlptl $ echo $? 0 ```
|
@all-contributors Please add @javierhonduco for code. |
|
I've put up a pull request to add @javierhonduco! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we download the x86 binaries even on arm, let's fetch
the
tilt+minikubebinaries for the matching architectureHad to bump
ctlptlto 0.5.1 as they started generating the arm64builds starting that version. Changes between v0.5.0-v0.5.1
Test plan:
$ ./env.sh % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 35 68.2M 35 24.4M 0 0 6040k 0 0:00:11 0:00:04 0:00:07 6039k^C [vagrant@bazinga parca]$ ./env.sh % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 68.2M 100 68.2M 0 0 6127k 0 0:00:11 0:00:11 --:--:-- 6057k + tar -xzv tilt + curl -fsSL https://github.com/tilt-dev/tilt/releases/download/v0.27.0/tilt.0.27.0.linux.arm64.tar.gz tilt + copy_binary + [[ :/home/vagrant/.local/bin:/home/vagrant/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/usr/local/go/bin:/bin:/usr/local/go/bin:/home/vagrant/go/bin: == *\:\/\h\o\m\e\/\v\a\g\r\a\n\t\/\.\l\o\c\a\l\/\b\i\n\:* ]] + '[' '!' -d /home/vagrant/.local/bin ']' + mv tilt /home/vagrant/.local/bin/tilt + set +x Tilt installed! For the latest Tilt news, subscribe: https://tilt.dev/subscribe Run `tilt up` to start. ctlptl $ echo $? 0