pkg/query: Fix diffing for distinct stacktraces #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
approved these changes
Apr 13, 2022
Previously we had a fast path for pre-processing diffs that are identical. It turns out that this fast path messed up the data and was hiding that some diffs were not done correctly. This primarily happened when non-merged different binaries are compared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a fast path for pre-processing diffs that are
identical. It turns out that this fast path messed up the data and was
hiding that some diffs were not done correctly. This primarily happened
when non-merged different binaries are compared.
cc @roidelapluie