feat: support border-spacing #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Sep 17, 2022
src/properties/mod.rs
Outdated
| @@ -805,6 +805,8 @@ define_properties! { | |||
| "inset-inline": InsetInline(InsetInline) shorthand: true, | |||
| "inset": Inset(Inset) shorthand: true, | |||
|
|
|||
| "border-spacing": BorderSpacing(BorderSpacing), | |||
There was a problem hiding this comment.
I think this could just be Size2D<Length> rather than needing a custom BorderSpacing type. Size2D already handles the parsing and omitting of the second value if it is equal to the first.
yisibl
force-pushed
the
border-spacing
branch
from
488c119
to
7c1a3e4
Compare
yisibl
commented
Sep 18, 2022
| // we may need to implement NonNegativeLength like Servo does. | ||
| // Servo Code: https://github.com/servo/servo/blob/08bc2d53579c9ab85415d4363888881b91df073b/components/style/values/specified/length.rs#L875 | ||
| // CSSWG issue: https://lists.w3.org/Archives/Public/www-style/2008Sep/0161.html | ||
| // `border-spacing = <length> <length>?` |
There was a problem hiding this comment.
@devongovett Do we need to implement NonNegativeLength?
There was a problem hiding this comment.
Eventually maybe. Right now it wouldn't have any effect on the output because we fall back to passing through the original value when an error occurs.
devongovett
approved these changes
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
border-spacing = <length> <length>?Spec: https://www.w3.org/TR/CSS22/tables.html#propdef-border-spacing