Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flipped border-bottom-right and border-bottom-left #308

Merged
merged 6 commits into from
Oct 24, 2022

Conversation

LeoniePhiline
Copy link
Contributor

@LeoniePhiline LeoniePhiline commented Sep 28, 2022

Fixes #307

This pull request:

  • Adds Border radius wrong output when using explicit radii #307 as test case and fixes it.
  • Adds another test case (for <first> <second> <third> / <first> <second> syntax) from MDN.
  • Fixes a previously false-positive test, caused by consistently placing bottom-left (or start-end) before bottom-right (or end-end)
  • Prevents future similar bugs and reduces confusion by consistently re-sorting bottom right before bottom left (matching CSS syntax) across the border radius module and tests.

A note about white space:
Some white space was inconsistent, but that was not meant to be subject of this PR. I accidentally committed the removal of spaces from otherwise empty lines, causing diff noise. With this accidental change, the post-merge code is more white-space-consistent, but nevertheless please let me know if I should revert these accidental white space changes.

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devongovett devongovett merged commit 6dc3ca0 into parcel-bundler:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border radius wrong output when using explicit radii
2 participants