Support raw
property on returned declarations in visitors
#385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a
raw
property to be provided instead ofvalue
when returning declarations from JS visitors. This will be parsed as a CSS value for the given property name as if it were written in a CSS file. This should make it easier to return known CSS values rather than constructing the full AST for them manually.To make this work, we needed an
into_owned()
method for all values with lifetimes so that we can parse the raw string and store the result in the AST without borrowing from it. This will be useful for other things as well, like substituting variable values. It is derived by a proc macro behind the "into_owned" feature flag.Another option would have been exposing a
parseProperty
function that would return a parsed AST from a string, but this would require more back and forth between JS and native which can have some overhead. Allowing raw CSS strings to be returned avoids this.