Substitute variables #388
Merged
Substitute variables #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321
This adds a
substitute_variablesfunction toUnparsedProperty, which will substitute variables provided in a HashMap with their values and return a newPropertycontaining the fully parsed version (if possible). It is implemented using the visitor and into_owned features, and is available under the substitute_variables feature. It works by first substituting the tokens, then printing the tokens to a string and finally reparsing them as an owned (i.e.'static) property. This is necessary because at this time cssparser doesn't offer a way to reuse the existing tokens when parsing.