Visitor: allow short-circuiting on error #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks this looks like a good feature. Will look more in depth soon! |
devongovett
approved these changes
Feb 9, 2023
…into georgeclaghorn-visitor-error
|
Thanks again and sorry for the delay in looking at this. I also updated the JS transformer to use the fallible visitor functions as well: 366d923. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Classmate, visitors call fallible Ruby methods. I’d like to stop traversal at the first error and propagate it back up to the caller.
I currently approximate that by storing the error on the visitor and wrapping each
Visitormethod’s body inif self.error.is_none() { ... }. It would be nicer if I could just return an error from a visitor method and let it bubble up. This PR makes that possible.The JS bindings’
JsVisitorintentionally remains infallible to preserve existing behavior, where it continues traversal after an error, but it could adopt the new behavior if desired.