feat: Make Visitor bounded by ?Sized
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops I found that |
|
@kdy1 I think we can remove that since there is a visit_types function instead. Most places seem to already use it. If we just make that function required instead it should be ok. The compiler should still be able to inline it if it is constant. https://github.com/parcel-bundler/lightningcss/blob/master/src/visitor.rs#L155 |
|
I did it |
devongovett
approved these changes
Sep 6, 2023
kdy1
added a commit
to swc-project/plugins
that referenced
this pull request
Sep 12, 2023
Related PR: parcel-bundler/lightningcss#574 --------- Co-authored-by: 강동윤 (Donny) <kdy1.users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not have to be
Sized.Real usage
I'm trying to use
lightningcssfor some SWC-related projects and I need to create a trait object ofVisitor