Find a[href] dependencies when attrs precede it (#487)

parcel-bundler · Jan 4, 2018 · 39c5cfe · 39c5cfe
1 parent e0e231e
commit 39c5cfe
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 1 deletion.
diff --git a/src/assets/HTMLAsset.js b/src/assets/HTMLAsset.js
@@ -44,7 +44,7 @@ class HTMLAsset extends Asset {
           let elements = ATTRS[attr];
           // Check for virtual paths
           if (node.tag === 'a' && node.attrs[attr].lastIndexOf('.') < 1) {
-            break;
+            continue;
           }
           if (elements && elements.includes(node.tag)) {
             let assetPath = this.addURLDependency(node.attrs[attr]);

diff --git a/test/html.js b/test/html.js
@@ -48,6 +48,22 @@ describe('html', function() {
     }
   });
 
+  it('should find href attr when not first', async function() {
+    let b = await bundle(__dirname + '/integration/html-attr-order/index.html');
+
+    assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'html',
+          assets: ['other.html'],
+          childBundles: []
+        }
+      ]
+    });
+  });
+
   it('should support transforming HTML with posthtml', async function() {
     let b = await bundle(__dirname + '/integration/posthtml/index.html');
 

diff --git a/test/integration/html-attr-order/index.html b/test/integration/html-attr-order/index.html
@@ -0,0 +1,9 @@
+<!doctype html>
+<html>
+<head>
+</head>
+<body>
+  <h1>Hello world</h1>
+  <p>Linking to <a class="link" href="other.html">another page</a></p>
+</body>
+</html>
diff --git a/test/integration/html-attr-order/other.html b/test/integration/html-attr-order/other.html
@@ -0,0 +1,8 @@
+<!doctype html>
+<html>
+<head>
+</head>
+<body>
+  <h1>Other page</h1>
+</body>
+</html>