Fix reference pass error in package config (#1149)

parcel-bundler · May 1, 2018 · a36b912 · a36b912
1 parent ec98a95
commit a36b912
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/assets/LESSAsset.js b/src/assets/LESSAsset.js
@@ -13,10 +13,10 @@ class LESSAsset extends Asset {
     let less = await localRequire('less', this.name);
     let render = promisify(less.render.bind(less));
 
-    let opts =
-      this.package.less ||
-      (await this.getConfig(['.lessrc', '.lessrc.js'])) ||
-      {};
+    let opts = Object.assign(
+      {},
+      this.package.less || (await this.getConfig(['.lessrc', '.lessrc.js']))
+    );
     opts.filename = this.name;
     opts.plugins = (opts.plugins || []).concat(urlPlugin(this));
 

diff --git a/src/assets/SASSAsset.js b/src/assets/SASSAsset.js
@@ -21,10 +21,10 @@ class SASSAsset extends Asset {
       rootDir: this.options.rootDir
     });
 
-    let opts =
-      this.package.sass ||
-      (await this.getConfig(['.sassrc', '.sassrc.js'])) ||
-      {};
+    let opts = Object.assign(
+      {},
+      this.package.sass || (await this.getConfig(['.sassrc', '.sassrc.js']))
+    );
     opts.includePaths = (opts.includePaths || []).concat(
       path.dirname(this.name)
     );

diff --git a/src/transforms/postcss.js b/src/transforms/postcss.js
@@ -31,7 +31,7 @@ async function getConfig(asset) {
     return;
   }
 
-  config = config || {};
+  config = Object.assign({}, config);
 
   let postcssModulesConfig = {
     getJSON: (filename, json) => (asset.cssModules = json)

diff --git a/src/transforms/posthtml.js b/src/transforms/posthtml.js
@@ -26,7 +26,7 @@ async function getConfig(asset) {
     return;
   }
 
-  config = config || {};
+  config = Object.assign({}, config);
   config.plugins = await loadPlugins(config.plugins, asset.name);
   config.skipParse = true;
   return config;