Only error for empty HTML dependency attributes

parcel-bundler · Nov 29, 2021 · c13917f · c13917f
1 parent cdc1d0e
commit c13917f
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 22 deletions.
diff --git a/packages/core/integration-tests/test/html.js b/packages/core/integration-tests/test/html.js
@@ -2718,7 +2718,7 @@ describe('html', function () {
         name: 'BuildError',
         diagnostics: [
           {
-            message: 'src should not be empty string',
+            message: "'src' should not be empty string",
             origin: '@parcel/transformer-html',
             codeFrames: [
               {
@@ -2744,7 +2744,7 @@ describe('html', function () {
           },
 
           {
-            message: 'src should not be empty string',
+            message: "'src' should not be empty string",
             origin: '@parcel/transformer-html',
             codeFrames: [
               {
@@ -2770,7 +2770,7 @@ describe('html', function () {
           },
 
           {
-            message: 'href should not be empty string',
+            message: "'href' should not be empty string",
             origin: '@parcel/transformer-html',
             codeFrames: [
               {

diff --git a/packages/core/integration-tests/test/integration/html-empty-reference/index.html b/packages/core/integration-tests/test/integration/html-empty-reference/index.html
@@ -1,3 +1,4 @@
 <img src="" />
 <script src=""></script>
-<link href="" />
+<link href="" />
+<input value="" checked data-x />
diff --git a/packages/transformers/html/src/dependencies.js b/packages/transformers/html/src/dependencies.js
@@ -254,17 +254,17 @@ export default function collectDependencies(
         continue;
       }
 
-      // Check for empty string
-      if (attrs[attr].length === 0) {
-        errors.push({
-          message: `${attr} should not be empty string`,
-          filePath: asset.filePath,
-          loc: node.location,
-        });
-      }
-
       let elements = ATTRS[attr];
       if (elements && elements.includes(node.tag)) {
+        // Check for empty string
+        if (attrs[attr].length === 0) {
+          errors.push({
+            message: `'${attr}' should not be empty string`,
+            filePath: asset.filePath,
+            loc: node.location,
+          });
+        }
+
         let depHandler = getAttrDepHandler(attr);
         let depOptionsHandler = OPTIONS[node.tag];
         let depOptions =

diff --git a/packages/transformers/svg/src/dependencies.js b/packages/transformers/svg/src/dependencies.js
@@ -107,17 +107,17 @@ export default function collectDependencies(asset: MutableAsset, ast: AST) {
         continue;
       }
 
-      // Check for empty string
-      if (attrs[attr].length === 0) {
-        errors.push({
-          message: `${attr} should not be empty string`,
-          filePath: asset.filePath,
-          loc: node.location,
-        });
-      }
-
       const elements = ATTRS[attr];
       if (elements && elements.includes(node.tag)) {
+        // Check for empty string
+        if (attrs[attr].length === 0) {
+          errors.push({
+            message: `'${attr}' should not be empty string`,
+            filePath: asset.filePath,
+            loc: node.location,
+          });
+        }
+
         let options = OPTIONS[tag]?.[attr];
         if (node.tag === 'script') {
           options = {