New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize require
call with template literals (but no placeholders)
#5492
Comments
@mischnic I'd love to pick up this issue |
@alphabet-codes sure, feel free to work on this |
Hey @DeMoorJasper is this issue still open and up for grabs? May I have a chance to provide a MR for this issue? Many thanks! |
@ognjenjevremovic Sure |
ognjenjevremovic
pushed a commit
to ognjenjevremovic/parcel
that referenced
this issue
Feb 23, 2021
Requiring packages with CommonJS and using template literals (instead of string literals) should behave exactly the same. Template literal expressions are not allowed in the CommonJS require calls. ✅ Closes: parcel-bundler#5492
3 tasks
This was referenced Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 bug report
should behave just like
require("lodash")
but are currently ignored.should still be ignored.
💁 Possible Solution
This case should be normalized here:
parcel/packages/transformers/js/src/visitors/dependencies.js
Lines 56 to 61 in a4cf3e9
and also normalized to
"lodash"
.Add a test similar to this one:
parcel/packages/core/integration-tests/test/javascript.js
Lines 24 to 35 in 46af247
The text was updated successfully, but these errors were encountered: