Making a require conditional requires clearing the cache

[mischnic]

🐛 bug report

Wrapping an existing dependency in an if statement doesn't wrap the dependency (with a cached build).

💁 Possible Solution

dep.meta.shouldWrap is overwritten when reading the dependency from cache?

💻 Code Sample

// if (Date.now() < 0) {
	const x = require("./something");

	console.log(x);
// }

1. parcel build index.js
2. Comment in the first and last line
3. parcel build index.js. something is still being executed.

🌍 Your Environment

Software	Version(s)
Parcel	560d060

[devongovett]

Still an issue?

[mischnic]

Yes, output of step 1:

var $30c2bb3b4d10773c$exports = {};
console.log("!");


console.log($30c2bb3b4d10773c$exports); // }

output of step 2 (the imported asset isn't wrapped):

var $30c2bb3b4d10773c$exports = {};
console.log("!");


if (Date.now() < 0) {
    const x = $30c2bb3b4d10773c$exports;
    console.log(x);
}

[devongovett]

I think this is the problem:

parcel/packages/core/core/src/AssetGraph.js

Lines 468 to 471 in 413a093

	if (existing) {
	invariant(existing.type === 'dependency');
	depNode.value.meta = existing.value.meta;
	}

Looks like it was added in 3edfae0

I guess it needs to somehow merge the meta properties added by the resolver with the properties returned by the transformer? We'd need to store these separately I suppose so that either request can re-run without the other re-running and the result should be the same. 🤔