Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eval usage. Fixes CSP cases. #1133

Merged
merged 3 commits into from
May 1, 2018
Merged

Remove eval usage. Fixes CSP cases. #1133

merged 3 commits into from
May 1, 2018

Commits on May 1, 2018

  1. Fix CSP issue while obtaining ref to global 

    Prevent violating Content Security Policy

fixes parcel-bundler#335
    @embiem @devongovett
    embiem authored and devongovett committed May 1, 2018
    Configuration menu
    Copy the full SHA
    87fea01 View commit details
    Browse the repository at this point in the history

  2. Completely remove eval usage from parcel. 

    The `global` object is aquired via `this` in a non-strict scope and then passed into each module.
    @CvX @devongovett
    CvX authored and devongovett committed May 1, 2018
    Configuration menu
    Copy the full SHA
    607a4d4 View commit details
    Browse the repository at this point in the history

  3. Handle re-declaration of the global variable in a module

    @devongovett
    devongovett committed May 1, 2018
    Configuration menu
    Copy the full SHA
    84be07b View commit details
    Browse the repository at this point in the history