Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for outFile option; respect file-extension (#1228) #1229

Merged
merged 2 commits into from May 3, 2018

Conversation

lqdchrm
Copy link
Contributor

@lqdchrm lqdchrm commented Apr 21, 2018

suggestion for a fix

thx for this awesome tool and keep up the good work 😄

Closes #1228

@codecov-io
Copy link

codecov-io commented Apr 21, 2018

Codecov Report

Merging #1229 into master will decrease coverage by 1.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   88.28%   87.22%   -1.07%     
==========================================
  Files          77       77              
  Lines        4355     4117     -238     
==========================================
- Hits         3845     3591     -254     
- Misses        510      526      +16
Impacted Files Coverage Δ
src/Bundle.js 98.42% <80%> (-0.77%) ⬇️
src/transforms/htmlnano.js 72.22% <0%> (-27.78%) ⬇️
src/workerfarm/errorUtils.js 64.7% <0%> (-17.65%) ⬇️
src/transforms/posthtml.js 84.37% <0%> (-15.63%) ⬇️
src/visitors/dependencies.js 81.52% <0%> (-13.05%) ⬇️
src/transforms/babel.js 88.55% <0%> (-6.97%) ⬇️
src/assets/HTMLAsset.js 85.14% <0%> (-3.97%) ⬇️
src/visitors/globals.js 92.3% <0%> (-3.85%) ⬇️
src/utils/config.js 86.95% <0%> (-1.45%) ⬇️
src/utils/getTargetEngines.js 96.8% <0%> (-1.07%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7f4aa...68e09fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

out-file option does not respect given file-extension
3 participants