Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Htmlnano don't remove redundant attributes #1249

Merged
merged 11 commits into from Apr 29, 2018

Conversation

DeMoorJasper
Copy link
Member

This will change the defaults of htmlnano to keep default values inside form elements, that could cause css selectors to fail.

Closes #1245

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #1249 into master will increase coverage by 1.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   87.38%   88.39%   +1.01%     
==========================================
  Files          77       77              
  Lines        4105     4455     +350     
==========================================
+ Hits         3587     3938     +351     
+ Misses        518      517       -1
Impacted Files Coverage Δ
src/transforms/htmlnano.js 100% <100%> (+27.77%) ⬆️
src/assets/WebManifestAsset.js 59.18% <0%> (-19.39%) ⬇️
src/assets/JSONAsset.js 84.61% <0%> (-8.72%) ⬇️
src/assets/VueAsset.js 80% <0%> (-7.5%) ⬇️
src/assets/SASSAsset.js 93.61% <0%> (-6.39%) ⬇️
src/assets/TypeScriptAsset.js 97.29% <0%> (-2.71%) ⬇️
src/assets/LESSAsset.js 97.87% <0%> (-2.13%) ⬇️
src/utils/serializeObject.js 88.23% <0%> (-1.77%) ⬇️
src/utils/syncPromise.js 100% <0%> (ø) ⬆️
src/assets/TOMLAsset.js 100% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a7882...acf33a9. Read the comment docs.

@devongovett
Copy link
Member

hmm we keep finding these unsafe transforms that htmlnano is doing. is there a flag to just turn them all off in one go rather than needing to manually apply each one as we find it?

@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented Apr 27, 2018

@devongovett Not that I know of, it doesn't mention it in the docs.
I've opened up an issue, with a feature request.

@devongovett devongovett merged commit ac3f8ca into master Apr 29, 2018
@devongovett devongovett deleted the fix/htmlnano-removeRedundantAttributes branch April 29, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants