Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing appveyor test #1431

Merged
merged 2 commits into from May 24, 2018
Merged

Fix failing appveyor test #1431

merged 2 commits into from May 24, 2018

Conversation

DeMoorJasper
Copy link
Member

Fixes a failing appveyor html test

@DeMoorJasper DeMoorJasper changed the title Fix failing appveyor Fix failing appveyor test May 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #1431 into master will increase coverage by 3.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   87.31%   90.32%   +3.01%     
==========================================
  Files          80       80              
  Lines        3800     6183    +2383     
==========================================
+ Hits         3318     5585    +2267     
- Misses        482      598     +116
Impacted Files Coverage Δ
src/assets/WebManifestAsset.js 59.18% <0%> (-19.39%) ⬇️
src/Logger.js 83.59% <0%> (-13.25%) ⬇️
src/packagers/CSSPackager.js 87.87% <0%> (-12.13%) ⬇️
src/assets/JSONAsset.js 84.61% <0%> (-8.72%) ⬇️
src/utils/getRootDir.js 86.11% <0%> (-8.34%) ⬇️
src/assets/VueAsset.js 80.72% <0%> (-7.06%) ⬇️
src/HMRServer.js 85% <0%> (-6.67%) ⬇️
src/Bundle.js 93.05% <0%> (-6.2%) ⬇️
src/packagers/JSPackager.js 82.74% <0%> (-5.83%) ⬇️
src/Pipeline.js 93.06% <0%> (-4.89%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1614918...471b302. Read the comment docs.

@fathyb fathyb merged commit 1cb05e0 into master May 24, 2018
@fathyb fathyb deleted the fix/appveyor-test branch May 24, 2018 13:03
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Fixes a failing appveyor html test
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Fixes a failing appveyor html test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants