Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async modules when possibles #1433

Merged
merged 2 commits into from May 24, 2018
Merged

Use async modules when possibles #1433

merged 2 commits into from May 24, 2018

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented May 24, 2018

  • Use the async version of glob in GlobAsset
  • Use the async version of resolve in localRequire

@DeMoorJasper DeMoorJasper merged commit 83dfa3e into master May 24, 2018
@DeMoorJasper DeMoorJasper deleted the fix/use-async branch May 24, 2018 13:50
devongovett pushed a commit that referenced this pull request Oct 15, 2018
@fathyb
Use async modules when possibles (#1433)
efde32f 
* Use async version of `resolve` for `localRequire`

* Use async version of `glob` for `GlobAsset`
devongovett pushed a commit that referenced this pull request Oct 15, 2018
@fathyb
Use async modules when possibles (#1433)
0f5ef4a 
* Use async version of `resolve` for `localRequire`

* Use async version of `glob` for `GlobAsset`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fathyb @DeMoorJasper