Fix sourcemap file size in report #1641
Conversation
| @@ -196,6 +196,8 @@ class Bundle { | |||
|
|
|||
| await packager.end(); | |||
|
|
|||
| this.totalSize = packager.getSize(); | |||
There was a problem hiding this comment.
This line updates bundle.totalSize to the actual final amount of written bytes instead of relying on addAsset to be called for every packager
There was a problem hiding this comment.
I think we will need to adjust the packager for tree shaking here or we'll get incorrect sizes:
parcel/src/packagers/JSConcatPackager.js
Line 508 in 3a8f38c
Can you change that to this.size = output.length? That way when we call getSize here after the bundle has finished we'll get the correct size.
There was a problem hiding this comment.
Fixed it in the latest commit
| @@ -196,6 +196,8 @@ class Bundle { | |||
|
|
|||
| await packager.end(); | |||
|
|
|||
| this.totalSize = packager.getSize(); | |||
There was a problem hiding this comment.
I think we will need to adjust the packager for tree shaking here or we'll get incorrect sizes:
parcel/src/packagers/JSConcatPackager.js
Line 508 in 3a8f38c
Can you change that to this.size = output.length? That way when we call getSize here after the bundle has finished we'll get the correct size.
Fixes #1635