adding support for node 10? #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't think the test failures are due to my changes. any way to stabilize the tests? |
|
Thanks! Can you add this to the appveyor config as well so node 10 tests run on windows as well? |
|
@devongovett done! |
|
still don't know why the CI fails |
devongovett
approved these changes
Jul 7, 2018
|
Yeah it's a bit flakey. Seems like some of the rust tests are failing currently. |
2zH
pushed a commit
to 2zH/parcel
that referenced
this pull request
Jul 11, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want to add node version 10 support?